Disable some flags in Apple x86_64 #3424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@abetlen reports some flags cannot work in Apple x86_64. Disable them by default. https://github.com/abetlen/llama-cpp-python/blob/b4939c2d99cb3b0e49bcaeee8731050deed9ccfe/CMakeLists.txt#L9-L16
|
@abetlen, I advise to move https://github.com/abetlen/llama-cpp-python/blob/b4939c2d99cb3b0e49bcaeee8731050deed9ccfe/CMakeLists.txt#L9-L16 |
Freed-Wu
added a commit
to Freed-Wu/llama-cpp-python
that referenced
this pull request
Oct 1, 2023
ggerganov/llama.cpp#3424 Move some code about disabling some flags in Apple x86 to the upstream Use ExternalProjectAdd() to simplify CMakeLists.txt Change base_path from llama_cpp to llama_cpp/data like other projects: - https://github.com/ssciwr/clang-format-wheel/blob/99df0fe0145e0af14c38772f1af78b215456e3a3/CMakeLists.txt#L44 - https://github.com/Freed-Wu/astyle-wheel/blob/340cef6dfd5cfa9158a321fe01b36df6a1e826e8/CMakeLists.txt#L12 - https://github.com/scikit-build/cmake-python-distributions/blob/13473f41061f73e599987af8dee5ba262e065769/setup.py#L46 - https://github.com/scikit-build/ninja-python-distributions/blob/e5510f4f725323b9be845a023bdc164718df1ddd/CMakeLists.txt#L149
|
These are just defaults - they are meant to be changed via the command line if you are on an older processor. This is not an Apple-specific concern. The build script currently does not warn if you are trying to use flags that are not compatible with the processor you are compiling on. |
|
Thanks, #3273 is awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abetlen reports some flags cannot work in Apple x86_64.
Disable them by default.
https://github.com/abetlen/llama-cpp-python/blob/b4939c2d99cb3b0e49bcaeee8731050deed9ccfe/CMakeLists.txt#L9-L16