Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not use ExternalProject() to replace git submodule? #464

Closed
Freed-Wu opened this issue Jul 9, 2023 · 2 comments
Closed

Why not use ExternalProject() to replace git submodule? #464

Freed-Wu opened this issue Jul 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Freed-Wu
Copy link

Freed-Wu commented Jul 9, 2023

Refer https://cmake.org/cmake/help/latest/module/ExternalProject.html
@gjmulder gjmulder added the enhancement New feature or request label Jul 9, 2023
@gjmulder
Copy link
Contributor

gjmulder commented Jul 9, 2023 

$ find . -name "*cmake*"
./vendor/llama.cpp/scripts/build-info.cmake
./.git/modules/vendor/llama.cpp/logs/refs/remotes/origin/cmake-change
./.git/modules/vendor/llama.cpp/refs/remotes/origin/cmake-change

@gjmulder gjmulder changed the title Why not use ExternelProject() to replace git submodule? Why not use ExternalProject() to replace git submodule? Jul 10, 2023
@Freed-Wu
Copy link
Author

What is the progress? 😄

@abetlen abetlen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2023
Freed-Wu added a commit to Freed-Wu/llama-cpp-python that referenced this issue Oct 1, 2023
@Freed-Wu
Fix abetlen#777, abetlen#464
00d772d 
ggerganov/llama.cpp#3424
Move some code about disabling some flags in Apple x86 to the upstream
Use ExternalProjectAdd() to simplify CMakeLists.txt
Change base_path from llama_cpp to llama_cpp/data like other projects:

- https://github.com/ssciwr/clang-format-wheel/blob/99df0fe0145e0af14c38772f1af78b215456e3a3/CMakeLists.txt#L44
- https://github.com/Freed-Wu/astyle-wheel/blob/340cef6dfd5cfa9158a321fe01b36df6a1e826e8/CMakeLists.txt#L12
- https://github.com/scikit-build/cmake-python-distributions/blob/13473f41061f73e599987af8dee5ba262e065769/setup.py#L46
- https://github.com/scikit-build/ninja-python-distributions/blob/e5510f4f725323b9be845a023bdc164718df1ddd/CMakeLists.txt#L149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abetlen @gjmulder @Freed-Wu