[naga spv-out] Document and refactor write_runtime_array_length.
#6334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
area: naga back-end
jimblandy
force-pushed
the
naga-spv-out-array-length-cleanup
branch
from
7611701 to
3470345
Compare
ErichDonGubler
approved these changes
Sep 27, 2024
jimblandy
force-pushed
the
naga-spv-out-array-length-cleanup
branch
from
3470345 to
1cf226d
Compare
jimblandy
force-pushed
the
naga-spv-out-array-length-cleanup
branch
from
1cf226d to
573aa75
Compare
Document and refactor `naga::back::spv::BlockContext::write_runtime_array_length`. Don't try to handle finding the length of a particular element of a `binding_array<array<T>>`. The SPIR-V backend doesn't wrap that type correctly anyway; gfx-rs#6333 changes the validator to forbid such types. Instead, assume that the elements of a `binding_array<T>` are always structs whose final members may be a runtime-sized array. Pull out consistency checks after the analysis of the array expression, so that we always carry out all the checks regardless of what path we took to produce the information.
jimblandy
force-pushed
the
naga-spv-out-array-length-cleanup
branch
from
573aa75 to
865dffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document and refactor
naga::back::spv::BlockContext::write_runtime_array_length.Don't try to handle finding the length of a particular element of a
binding_array<array<T>>. The SPIR-V backend doesn't wrap that type correctly anyway; [naga] Permit only structs as binding array elements. #6333 changes the validator to forbid such types. Instead, assume that the elements of abinding_array<T>are always structs whose final members may be a runtime-sized array.Pull out consistency checks after the analysis of the array expression, so that we always carry out all the checks regardless of what path we took to produce the information.
Update Vulkan spec section number, and provide link.
Replace
matchwith equivalent!=.