Make GPUProgrammableStage.entryPoint optional in wgpu-core
#5306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: ecosystem
8 tasks
ErichDonGubler
force-pushed
the
optional-entry_point-in-core
branch
from
632d532 to
193612f
Compare
ErichDonGubler
changed the title
GPUProgrammableStage.entryPoint optional in wgpu-core
ErichDonGubler
force-pushed
the
optional-entry_point-in-core
branch
from
193612f to
aae877e
Compare
ErichDonGubler
force-pushed
the
optional-entry_point-in-core
branch
from
295f9e5 to
eee0797
Compare
ErichDonGubler
commented
Feb 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ErichDonGubler
force-pushed
the
optional-entry_point-in-core
branch
2 times, most recently
from
20fa2a8 to
48b4c4e
Compare
cwfitzgerald
approved these changes
Feb 27, 2024
This is done to exercise the prior change.
ErichDonGubler
force-pushed
the
optional-entry_point-in-core
branch
from
ffbf609 to
5a2125a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Part of the work necessary for #5148, which resolves #5145. Unblocks agents like Firefox implementing this in their own environment as a first, easier step.
Description
Describe what problem this is solving, and how it's solved.
An optional entry point is now part of the WebGPU standard, and we should adhere to it; see also gpuweb/gpuweb#4342.
Testing
Explain how this change is tested.
Some tests in
player/tests/now exercise this via traces' specification ofentry_point: None. However, there's nowgpu-coreAPI tests exercising this, ATM. I think this is fine until such time that #5148 has merged, which should have more comprehensive testing overwgpu.I expect that some coverage of this will be added over time; tracking this at gpuweb/cts#3432.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.