feat: make ProgrammableStage::entry_point optional
#5148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
force-pushed
the
optional-entry_point
branch
6 times, most recently
from
1ebdb0a to
5eb6f37
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
5eb6f37 to
1484b28
Compare
6 tasks
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
1484b28 to
8540262
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
8540262 to
07aa705
Compare
ErichDonGubler
changed the title
ProgrammableStage::entry_point optionalProgrammableStage::entry_point optional
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
07aa705 to
9d8c869
Compare
6 tasks
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
9d8c869 to
3013b7f
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
3013b7f to
8bfc721
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
2 times, most recently
from
309e8b7 to
f826f1a
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
f826f1a to
6bae1ac
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
6bae1ac to
6e7e3fb
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
6e7e3fb to
d3283d6
Compare
ErichDonGubler
added
area: api
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
d3283d6 to
0c2f01b
Compare
ErichDonGubler
force-pushed
the
optional-entry_point
branch
from
0c2f01b to
0c2eb07
Compare
ErichDonGubler
changed the title
ProgrammableStage::entry_point optionalProgrammableStage::entry_point optional
nical
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Resolves #5145.
GPUProgrammableStage.entryPointoptional inwgpu-core#5306.Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.