Fix panic when creating a surface while no backend is available #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
approved these changes
Jan 31, 2024
Wumpf
added
the
PR: needs back-porting
Wumpf
deleted the
fix-surface-creation-crash-when-no-adapters-are-available
branch
cwfitzgerald
removed
the
PR: needs back-porting
|
This fix wasn't backported to 0.19.3 which was released at the same time as the "needs back-porting" label was removed. Seems like an error. |
|
The label was removed because this is a breaking change, thus can't be back ported to 0.19.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
connected to
SurfaceTargetenum #4984at first I thought I introduced the unwrap, but it was already there (still guilty, why did I not forsee this -.-)
Description
Fixes crash via unwrap when trying to create a surface on an instance that has no workable backend availble (e.g. try to create a surface when an instance is limited to dx12 on a metal device)
Testing
It compiles and there's an
unwrapless!Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.