Skip to content

Conversation

@cwfitzgerald
Copy link
Member

No description provided.

nical and others added 8 commits January 21, 2024 18:19
…5096)

My understanding is that we shouldn't need to (The d3d12 docs aren't very specific about that), but we have evidence that these functions sometimes leave the resource pointer set to null without returning an error.
gfx-rs#5091)

* Make sure to copy all of the buffers into the resource array for dx12.

Fixes gfx-rs#5088. Even though we're telling DX12 that the maximum frame latency should be our non-padded value, the swap chain may request any of the buffers allocated to it.

* Up the maximum frame latency on the DX12 backend to allow a larger range.
* [d3d12] use plane 1 for stencil only views

* add test

* skip stencil only view creation on WebGL
…#5093)

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 21, 2024 23:39
@cwfitzgerald cwfitzgerald merged commit b8a8ff6 into gfx-rs:v0.19 Jan 22, 2024
@cwfitzgerald cwfitzgerald deleted the release-0.19.1 branch January 22, 2024 00:22
@Friz64
Copy link
Contributor

Friz64 commented Jan 22, 2024

No #4967?

@cwfitzgerald
Copy link
Member Author

cwfitzgerald commented Jan 22, 2024

No, it breaks wgpu-hal (adds a parameter to Queue::submit). I had intended to include it.

@Friz64
Copy link
Contributor

Friz64 commented Jan 22, 2024

Oh, unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants