[d3d12] use plane 1 for stencil only views #5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
Jan 19, 2024
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Let's land this as it's, but could we get a test which makes a texture view of every type for each texture - for that matter, why wasn't this caught by a clear test for the stencil aspect?
Member
Author
I think that's because we clear textures with depth/stencil formats with render passes where we use a different format. I added a test for depth only and stencil only view creation. |
Member
|
CI for Windows failed, but only on artifact upload, and not tests running. I think this is good to merge, then! |
ErichDonGubler
approved these changes
Jan 19, 2024
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Jan 21, 2024
* [d3d12] use plane 1 for stencil only views * add test * skip stencil only view creation on WebGL
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5097.