Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ash to 0.37 #2557

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Update ash to 0.37 #2557

merged 1 commit into from
Mar 28, 2022

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Mar 24, 2022 •
edited
Loading

This raises MSRV to 1.59, not sure if this is acceptable.

cwfitzgerald
cwfitzgerald approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but MSRV bump needs a look by @kvark - who are the stakeholders who might have an issue with this?

@cwfitzgerald cwfitzgerald requested a review from kvark March 25, 2022 16:24
@kvark
Copy link
Member

kvark commented Mar 27, 2022

We should give a heads up to Bevy, Dotrix, Rend3, etc.
Not as much worried about Gecko, since it's very close to the latest stable at all times.

@a1phyr
Copy link
Contributor Author

a1phyr commented Mar 27, 2022

I did a little investigation:

  • Bevy uses latest stable
  • Rend3 uses 1.57
  • I could not find the information for Dotrix and Vange-rs
  • Veloren uses nightly but is still using an old wgpu version anyway

@kvark
Copy link
Member

kvark commented Mar 28, 2022

Thank you!
So let's go with it.

@kvark kvark enabled auto-merge (squash) March 28, 2022 04:06
@kvark kvark disabled auto-merge March 28, 2022 05:15
@kvark kvark merged commit d45e6b4 into gfx-rs:master Mar 28, 2022
@jimblandy jimblandy mentioned this pull request Apr 6, 2022
Closed
@jakobhellermann jakobhellermann mentioned this pull request Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a1phyr @kvark @cwfitzgerald