Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ash to 0.37 breaks Firefox #2580

Closed
jimblandy opened this issue Apr 6, 2022 · 3 comments
Closed

Updating ash to 0.37 breaks Firefox #2580

jimblandy opened this issue Apr 6, 2022 · 3 comments
Labels
area: ecosystem Help the connected projects grow and prosper

Comments

@jimblandy
Copy link
Member

#2557 updated wgpu-hal to Ash 0.37, which requires Rust 1.59. Unfortunately, Firefox is still using Rust 1.57 for builds.

I'll investigate when Mozilla plans to bring Firefox forward to 1.59. But we urgently need the fixes in #2567 and #2565, so it would be very helpful if we could back out #2557 for the time being.
@jimblandy
Copy link
Member Author

It seems like Firefox might be willing to move their MSRV forward to 1.59.

@kvark
Copy link
Member

kvark commented Apr 6, 2022

Interesting. Last time I checked Firefox kept going just 2 weeks behind the latest stable. But 1.57 is the whole 12 weeks behind.

@kvark kvark added the area: ecosystem Help the connected projects grow and prosper label Apr 6, 2022
@jimblandy
Copy link
Member Author

All sorted out - Firefox now requires 1.59.

cwfitzgerald pushed a commit that referenced this issue Oct 25, 2023
@jimblandy
[wgsl-in] Let lowering contexts point to a Function directly. (#2580)
86b6db6 
Change `StatementContext` and `RuntimeExpressionContext` in
`front::wgsl::lower` to hold a `&mut crate::Function` reference,
rather than separate pointers to individual fields of the `Function`.
This replaces three fields with one, and clarifies their
relationships.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ecosystem Help the connected projects grow and prosper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @jimblandy