Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Explicitly initialize snuba take 2" #3340

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

volokluev
Copy link
Member

Caused a crashloop again sigh

Reverts #3326

@volokluev volokluev requested a review from a team as a code owner November 3, 2022 22:57
@volokluev volokluev enabled auto-merge (squash) November 3, 2022 22:57
@codecov-commenter
Copy link

Codecov Report

Base: 91.24% // Head: 21.83% // Decreases project coverage by -69.40% ⚠️

Coverage data is based on head (1256d53) compared to base (a679cdf).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 1256d53 differs from pull request most recent head 61e0965. Consider uploading reports for the commit 61e0965 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3340       +/-   ##
===========================================
- Coverage   91.24%   21.83%   -69.41%     
===========================================
  Files         704      662       -42     
  Lines       32232    31028     -1204     
===========================================
- Hits        29409     6774    -22635     
- Misses       2823    24254    +21431     
Impacted Files Coverage Δ
snuba/cli/__init__.py 0.00% <0.00%> (-86.96%) ⬇️
snuba/datasets/factory.py 0.00% <0.00%> (-94.60%) ⬇️
tests/base.py 0.00% <0.00%> (-100.00%) ⬇️
tests/helpers.py 0.00% <0.00%> (-100.00%) ⬇️
tests/conftest.py 0.00% <0.00%> (-100.00%) ⬇️
tests/fixtures.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_cli.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_util.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/admin/user.py 0.00% <0.00%> (-100.00%) ⬇️
tests/assertions.py 0.00% <0.00%> (-100.00%) ⬇️
... and 615 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@volokluev volokluev merged commit 8355348 into master Nov 3, 2022
@volokluev volokluev deleted the revert-3326-volo/fix_init branch November 3, 2022 23:16
volokluev pushed a commit that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants