Explicitly initialize snuba take 2 #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2022 10:26
volokluev
commented
Nov 1, 2022
Comment on lines
+48
to
+53
| # IMPORTANT!!!! | ||
| # Click replaces underscores with dashes for command names | ||
| # by default. To mimic this behavior we have to do that here | ||
| # since all of our infrastructure depends on this being the | ||
| # case | ||
| actual_command_name = name.replace("-", "_") |
Comment on lines
+37
to
+42
| # IMPORTANT!!!! | ||
| # Click replaces underscores with dashes for command names | ||
| # by default. To mimic this behavior we have to do that here | ||
| # since all of our infrastructure depends on this being the | ||
| # case | ||
| rv.append(filename[:-3].replace("_", "-")) |
evanh
approved these changes
Nov 1, 2022
True but presumably they would run the command at least once before checking it in |
volokluev
added a commit
that referenced
this pull request
Nov 3, 2022
volokluev
pushed a commit
that referenced
this pull request
Nov 4, 2022
volokluev
added a commit
that referenced
this pull request
Nov 7, 2022
Compiling changes in #3311 and #3326 and moving the initialization up before subcommand compilation The deploy of #3326 caused a crashloop on `snuba-generic-metrics-distributions-subscriptions-scheduler-production`and `snuba-generic-metrics-distributions-subscriptions-scheduler-production` (and only those two) This happened because: 1. generic_metrics entities are defined in config 2. the subscriptions scheduler cli has the entity argument defined like so: ``` @click.option( "--entity", "entity_name", required=True, type=click.Choice([entity_key.value for entity_key in EntityKey]), help="The entity to target", ) ``` This makes the cli depend on the entity key being fully populated *at import time*. This also makes it so that the code as is only work *by accident*. ## The fix We move up initialization *before* we compile the subcommand code so that all the entity factories are initialized at import time ## The test This issue was reproducible locally by trying to run those consumer groups `snuba devserver` did not call those commands either. They have been added. Undoing the fix will make this command fail: ``` SEPARATE_SCHEDULER_EXECUTOR_SUBSCRIPTIONS_DEV=1 ENABLE_METRICS_SUBSCRIPTIONS=1 ENABLE_SENTRY_METRICS_DEV=1 snuba devserver ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the same as #3311 with the only difference being the name transformation
if you have a click command like this:
it will be accessible in the cli as
my-command. #3311 naively expected it to bemy_command.This PR fixes that and adds a comment explaining why it's important
Testing
Today I remembered about the
snuba devservercommand which starts up everything with the correct names. If I had done that initially I wouldn't have had to revert.With this change,
snuba devserverstarts up properly (before it did not)