Skip to content

feat(feedback): Hide the URL section for mobile projects #94680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 3 additions & 35 deletions static/app/components/feedback/feedbackItem/feedbackItem.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import {Fragment, useEffect, useRef} from 'react';
import {useTheme} from '@emotion/react';
import styled from '@emotion/styled';

import {openNavigateToExternalLinkModal} from 'sentry/actionCreators/modal';
import AnalyticsArea from 'sentry/components/analyticsArea';
import ErrorBoundary from 'sentry/components/errorBoundary';
import {getOrderedContextItems} from 'sentry/components/events/contexts';
Expand All @@ -13,13 +11,13 @@ import FeedbackActivitySection from 'sentry/components/feedback/feedbackItem/fee
import FeedbackItemHeader from 'sentry/components/feedback/feedbackItem/feedbackItemHeader';
import FeedbackItemSection from 'sentry/components/feedback/feedbackItem/feedbackItemSection';
import FeedbackReplay from 'sentry/components/feedback/feedbackItem/feedbackReplay';
import FeedbackUrl from 'sentry/components/feedback/feedbackItem/feedbackUrl';
import MessageSection from 'sentry/components/feedback/feedbackItem/messageSection';
import TraceDataSection from 'sentry/components/feedback/feedbackItem/traceDataSection';
import {KeyValueData} from 'sentry/components/keyValueData';
import PanelItem from 'sentry/components/panels/panelItem';
import QuestionTooltip from 'sentry/components/questionTooltip';
import TextCopyInput from 'sentry/components/textCopyInput';
import {IconChat, IconFire, IconLink, IconTag} from 'sentry/icons';
import {IconChat, IconFire, IconTag} from 'sentry/icons';
import {t} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {Event} from 'sentry/types/event';
Expand All @@ -35,11 +33,7 @@ interface Props {

export default function FeedbackItem({feedbackItem, eventData}: Props) {
const organization = useOrganization();
const url =
eventData?.contexts?.feedback?.url ??
eventData?.tags?.find(tag => tag.key === 'url')?.value;
const crashReportId = eventData?.contexts?.feedback?.associated_event_id;
const theme = useTheme();

const overflowRef = useRef<HTMLDivElement>(null);
useEffect(() => {
Expand All @@ -51,11 +45,6 @@ export default function FeedbackItem({feedbackItem, eventData}: Props) {
}, 100);
}, [feedbackItem.id, overflowRef]);

const URL_NOT_FOUND = t('URL not found');
const displayUrl =
eventData?.contexts?.feedback || eventData?.tags ? (url ?? URL_NOT_FOUND) : '';
const urlIsLink = displayUrl.length && displayUrl !== URL_NOT_FOUND;

return (
<Fragment>
<AnalyticsArea name="details">
Expand All @@ -65,28 +54,7 @@ export default function FeedbackItem({feedbackItem, eventData}: Props) {
<MessageSection eventData={eventData} feedbackItem={feedbackItem} />
</FeedbackItemSection>

{!crashReportId || (crashReportId && url) ? (
<FeedbackItemSection
collapsible
icon={<IconLink size="xs" />}
sectionKey="url"
title={t('URL')}
>
<TextCopyInput
style={urlIsLink ? {color: theme.blue400} : undefined}
onClick={
urlIsLink
? e => {
e.preventDefault();
openNavigateToExternalLinkModal({linkText: displayUrl});
}
: () => {}
}
>
{displayUrl}
</TextCopyInput>
</FeedbackItemSection>
) : null}
<FeedbackUrl eventData={eventData} feedbackItem={feedbackItem} />

{crashReportId && feedbackItem.project ? (
<FeedbackItemSection
Expand Down
67 changes: 67 additions & 0 deletions static/app/components/feedback/feedbackItem/feedbackUrl.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import {useTheme} from '@emotion/react';
import styled from '@emotion/styled';

import {openNavigateToExternalLinkModal} from 'sentry/actionCreators/modal';
import FeedbackItemSection from 'sentry/components/feedback/feedbackItem/feedbackItemSection';
import TextCopyInput from 'sentry/components/textCopyInput';
import {frontend} from 'sentry/data/platformCategories';
import {IconLink} from 'sentry/icons';
import {t} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import type {FeedbackIssue} from 'sentry/utils/feedback/types';

const URL_NOT_FOUND = t('URL not found');

interface Props {
eventData: Event | undefined;
feedbackItem: FeedbackIssue;
}

export default function FeedbackUrl({eventData, feedbackItem}: Props) {
const theme = useTheme();

const isFrontend = frontend.includes(feedbackItem.project?.platform ?? 'other');
if (!isFrontend) {
return null;
}

const url =
eventData?.contexts?.feedback?.url ??
eventData?.tags?.find(tag => tag.key === 'url')?.value;
const crashReportId = eventData?.contexts?.feedback?.associated_event_id;
if (crashReportId && !url) {
return null;
}

const urlIsExpected = eventData?.contexts?.feedback || eventData?.tags;
const displayUrl = urlIsExpected ? String(url ?? URL_NOT_FOUND) : undefined;
const urlIsLink = displayUrl && displayUrl !== URL_NOT_FOUND;
return (
<FeedbackItemSection
collapsible
icon={<IconLink size="xs" />}
sectionKey="url"
title={t('URL')}
>
<StyledTextCopyInput
style={urlIsLink ? {cursor: 'pointer', color: theme.blue400} : undefined}
onClick={
urlIsLink
? e => {
e.preventDefault();
openNavigateToExternalLinkModal({linkText: displayUrl});
}
: () => {}
}
>
{displayUrl ?? ''}
</StyledTextCopyInput>
</FeedbackItemSection>
);
}

const StyledTextCopyInput = styled(TextCopyInput)`
& > input:hover {
text-decoration: underline;
}
`;
Loading