feat(feedback): Hide the URL section for mobile projects #94680
+63
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes REPLAY-454
github-actions
bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Jul 1, 2025
| eventData?.tags?.find(tag => tag.key === 'url')?.value; | ||
| const crashReportId = eventData?.contexts?.feedback?.associated_event_id; | ||
| const displayUrl = | ||
| eventData?.contexts?.feedback || eventData?.tags ? (url ?? URL_NOT_FOUND) : ''; |
There was a problem hiding this comment.
can we just directly check if url exists? instead of doing the checks on eventData again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the Url section when a project is not a 'frontend' project.
For example, a cocoa project vs. a javascript (web) one. The specific feedback the user submitted doesn't matter in this case.
Fixes REPLAY-454