Skip to content

fix(aci): add issue_priority_equals condition to UI ignore list #94661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025
+2 −2
Merged

fix(aci): add issue_priority_equals condition to UI ignore list #94661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bace36
fix(aci): add condition to UI ignore list
ameliahsu Jun 30, 2025
9889167
remove every event from ignore
ameliahsu Jun 30, 2025
f8bbe99
fix test
ameliahsu Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/workflow_engine/models/data_condition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ class Condition(StrEnum):

# Conditions that are not supported in the UI
LEGACY_CONDITIONS = [
Condition.EVERY_EVENT,
Condition.EVENT_CREATED_BY_DETECTOR,
Condition.EVENT_SEEN_COUNT,
Condition.NEW_HIGH_PRIORITY_ISSUE,
Condition.EXISTING_HIGH_PRIORITY_ISSUE,
Condition.ISSUE_CATEGORY,
Condition.ISSUE_RESOLUTION_CHANGE,
Condition.ISSUE_PRIORITY_EQUALS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to this - i just noticed the Condition.EVERY_EVENT too -- fyi, if we want the Automation UI to have "Every Occurrence" kind of concept in it, we could reuse that condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, i'll remove EVERY_EVENT from the ignore list 🫡

]


Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/workflow_engine/endpoints/test_organization_data_condition_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class TestDetectorTrigger(DataConditionHandler):
comparison_json_schema = {"type": "boolean"}

# This legacy condition should not be included in the response
@self.registry.register(Condition.EVERY_EVENT)
@self.registry.register(Condition.EXISTING_HIGH_PRIORITY_ISSUE)
@dataclass(frozen=True)
class TestIgnoredCondition(DataConditionHandler):
group = DataConditionHandler.Group.WORKFLOW_TRIGGER
Expand Down
Loading