Skip to content

fix(aci): add issue_priority_equals condition to UI ignore list #94661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ameliahsu
Copy link
Member

@ameliahsu ameliahsu commented Jun 30, 2025

we are using issue_priority_greater_or_equal instead of issue_priority_equals

this ignore list is just used by the data condition index endpoint that returns all data conditions options for the automation builder UI

if condition_type not in LEGACY_CONDITIONS and handler.group == group:

@ameliahsu ameliahsu requested a review from a team as a code owner June 30, 2025 22:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 30, 2025
@ameliahsu ameliahsu changed the title fix(aci): add 'issue_priority_equals condition to UI ignore list fix(aci): add issue_priority_equals condition to UI ignore list Jun 30, 2025
@@ -99,6 +99,7 @@ class Condition(StrEnum):
Condition.EXISTING_HIGH_PRIORITY_ISSUE,
Condition.ISSUE_CATEGORY,
Condition.ISSUE_RESOLUTION_CHANGE,
Condition.ISSUE_PRIORITY_EQUALS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to this - i just noticed the Condition.EVERY_EVENT too -- fyi, if we want the Automation UI to have "Every Occurrence" kind of concept in it, we could reuse that condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, i'll remove EVERY_EVENT from the ignore list 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants