chore(launchpad): actually delete preprodartifact.analysis_file_id

[NicoHinderling]

must wait until #94657 is fully deployed to merge

[NicoHinderling]

• chore(launchpad): actually delete preprodartifact.analysis_file_id #94658 👈 (View in Graphite)
• chore(launchpad): soft delete preprodartifact.analysis_file_id #94657
• chore(launchpad): change size analysis upload logic to create/update size metrics table #94656
• chore(launchpad): create replacement analysis_file_id col in preprod size metrics table #94655
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0008_make_preprod_analysis_file_id_in_size_metrics_table.py src/sentry/preprod/migrations/0009_drop_preprod_artifact_analysis_file_id_col.py src/sentry/preprod/migrations/0010_actual_drop_preprod_artifact_analysis_file_id_col.py

for 0008_make_preprod_analysis_file_id_in_size_metrics_table in preprod

--
-- Add field analysis_file_id to preprodartifactsizemetrics
--
ALTER TABLE "sentry_preprodartifactsizemetrics" ADD COLUMN "analysis_file_id" bigint NULL;
CREATE INDEX CONCURRENTLY "sentry_preprodartifactsizemetrics_analysis_file_id_f7c6d67f" ON "sentry_preprodartifactsizemetrics" ("analysis_file_id");

for 0009_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Moved preprodartifact.analysis_file_id field to pending deletion state
--
-- (no-op)

for 0010_actual_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Remove field analysis_file_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "analysis_file_id" CASCADE;

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0009_drop_preprod_artifact_analysis_file_id_col.py src/sentry/preprod/migrations/0010_actual_drop_preprod_artifact_analysis_file_id_col.py

for 0009_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Moved preprodartifact.analysis_file_id field to pending deletion state
--
-- (no-op)

for 0010_actual_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Remove field analysis_file_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "analysis_file_id" CASCADE;

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0010_actual_drop_preprod_artifact_analysis_file_id_col.py

for 0010_actual_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Remove field analysis_file_id from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "analysis_file_id" CASCADE;

[cursor]

Bug: Migration Timing Error: Incorrect `is_post_deployment` Setting

The migration 0010_actual_drop_preprod_artifact_analysis_file_id_col incorrectly sets is_post_deployment = False. This migration drops the analysis_file_id column from preprodartifact. As a schema alteration, and critically, due to an explicit dependency on PR #94657 (which removes code references to this field) being fully deployed, this setting creates a timing issue. The column could be dropped during deployment before the code changes are deployed, potentially causing runtime errors. is_post_deployment should be True to ensure the migration runs only after the code is deployed.

src/sentry/preprod/migrations/0010_actual_drop_preprod_artifact_analysis_file_id_col.py#L20-L21

sentry/src/sentry/preprod/migrations/0010_actual_drop_preprod_artifact_analysis_file_id_col.py

Lines 20 to 21 in 1e776c5

	is_post_deployment = False

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎