Skip to content

chore(launchpad): soft delete preprodartifact.analysis_file_id #94657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NicoHinderling
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 30, 2025
@NicoHinderling NicoHinderling marked this pull request as ready for review June 30, 2025 20:54
@NicoHinderling NicoHinderling requested a review from a team as a code owner June 30, 2025 20:54
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0008_make_preprod_analysis_file_id_in_size_metrics_table.py src/sentry/preprod/migrations/0009_drop_preprod_artifact_analysis_file_id_col.py

for 0008_make_preprod_analysis_file_id_in_size_metrics_table in preprod

--
-- Add field analysis_file_id to preprodartifactsizemetrics
--
ALTER TABLE "sentry_preprodartifactsizemetrics" ADD COLUMN "analysis_file_id" bigint NULL;
CREATE INDEX CONCURRENTLY "sentry_preprodartifactsizemetrics_analysis_file_id_f7c6d67f" ON "sentry_preprodartifactsizemetrics" ("analysis_file_id");

for 0009_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Moved preprodartifact.analysis_file_id field to pending deletion state
--
-- (no-op)

@NicoHinderling NicoHinderling force-pushed the 06-30-chore_launchpad_change_size_analysis_upload_logic_to_create_update_size_metrics_table branch from ec930e9 to 221dedf Compare June 30, 2025 21:08
@NicoHinderling NicoHinderling force-pushed the 06-30-chore_launchpad_soft_delete_preprodartifact.analysis_file_id branch 3 times, most recently from fd64ede to 423ccba Compare June 30, 2025 21:17
@NicoHinderling NicoHinderling force-pushed the 06-30-chore_launchpad_change_size_analysis_upload_logic_to_create_update_size_metrics_table branch from 011197c to fe84025 Compare June 30, 2025 22:19
@NicoHinderling NicoHinderling force-pushed the 06-30-chore_launchpad_soft_delete_preprodartifact.analysis_file_id branch from 423ccba to 14a8e46 Compare June 30, 2025 22:19
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0009_drop_preprod_artifact_analysis_file_id_col.py

for 0009_drop_preprod_artifact_analysis_file_id_col in preprod

--
-- Moved preprodartifact.analysis_file_id field to pending deletion state
--
-- (no-op)

@NicoHinderling NicoHinderling force-pushed the 06-30-chore_launchpad_soft_delete_preprodartifact.analysis_file_id branch from 14a8e46 to 7b6eff2 Compare June 30, 2025 22:22
Base automatically changed from 06-30-chore_launchpad_change_size_analysis_upload_logic_to_create_update_size_metrics_table to master June 30, 2025 22:43
@NicoHinderling NicoHinderling force-pushed the 06-30-chore_launchpad_soft_delete_preprodartifact.analysis_file_id branch from 7b6eff2 to 60fed41 Compare June 30, 2025 22:43
@NicoHinderling NicoHinderling enabled auto-merge (squash) June 30, 2025 22:44
@NicoHinderling NicoHinderling merged commit d086bd5 into master Jun 30, 2025
65 of 66 checks passed
@NicoHinderling NicoHinderling deleted the 06-30-chore_launchpad_soft_delete_preprodartifact.analysis_file_id branch June 30, 2025 23:02
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #94657      +/-   ##
==========================================
- Coverage   87.92%   86.62%   -1.30%     
==========================================
  Files       10425    10426       +1     
  Lines      603143   603149       +6     
  Branches    23470    23470              
==========================================
- Hits       530292   522460    -7832     
- Misses      72345    80183    +7838     
  Partials      506      506              

NicoHinderling added a commit that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants