Repository navigation
fix(spans): Rename span buf prefix - #92617
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
untitaker
approved these changes
Jun 2, 2025
jan-auer
enabled auto-merge (squash)
June 2, 2025 11:19
untitaker
added a commit
that referenced
this pull request
Jun 2, 2025
- **Revert "fix(spans): Rename span buf prefix (#92617)"** - **Revert "feat(spans): Evict spans during insert (#92393)"** This PR incurred 30% overhead on insert_spans. We only see this reported from the consumer/client -- we don't see additional time spent in redis commands as reported by the cluster itself.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Fixes a regression in #92393, where we changed the type of data in keys without renaming the keys. This PR changes the namespace, which is equivalent to flushing the DB.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
- **Revert "fix(spans): Rename span buf prefix (#92617)"** - **Revert "feat(spans): Evict spans during insert (#92393)"** This PR incurred 30% overhead on insert_spans. We only see this reported from the consumer/client -- we don't see additional time spent in redis commands as reported by the cluster itself.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in #92393, where we changed the type of data in keys without
renaming the keys. This PR changes the namespace, which is equivalent to
flushing the DB.
Ref STREAM-162