Repository navigation
feat(spans): Evict spans during insert - #92393
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
* master: (249 commits) feat(source-maps): Do not show pagination together with empty state (#92287) ref(project-creation): Introduce useCreateProjectRules hook (#92186) feat(agent-insights): Handle new keys (#92613) feat(source-maps): Introduce new empty state copies and react-native callout (#92286) ref(issues): Remove project from group activity type (#92600) feat(ourlogs): Use /trace-logs endpoint (#92577) feat(issues): Only update group hasSeen when user is member (#92597) fix(workflow_engine): Graceful Data Condition Eval Handling (#92591) feat(uptime): Implement detector handler (#91107) chore(autofix): Remove logs from response payload (#92589) fix(search): Fix issue with tags name 'constructor' (#92586) fix(autofix): Fix condition for onboarding check (#92584) fix(ourlogs): Return the same format as /events & limit 1000 for trace-logs (#92580) fix(autofix): Fix automation onboarding condition (#92579) feat(explore): Remove group by timestamp from explore (#92546) feat(trace-items): Autocomplete for semver attributes (#92515) feat(processing) Define EventProcessingStore.__all__ (#92555) feat(autofix): Better errored state (#92571) chore(autofix): Seer beta banner copy changes (#92576) feat(crons): Add endpoint to return counts by status (#92574) ...
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92393 +/- ##
==========================================
+ Coverage 87.89% 87.96% +0.07%
==========================================
Files 10240 10217 -23
Lines 587447 586303 -1144
Branches 22816 22623 -193
==========================================
- Hits 516321 515763 -558
+ Misses 70696 70126 -570
+ Partials 430 414 -16 |
untitaker
approved these changes
Jun 2, 2025
jan-auer
added a commit
that referenced
this pull request
Jun 2, 2025
Fixes a regression in #92393, where we changed the type of data in keys without renaming the keys. This PR changes the namespace, which is equivalent to flushing the DB.
untitaker
added a commit
that referenced
this pull request
Jun 2, 2025
- **Revert "fix(spans): Rename span buf prefix (#92617)"** - **Revert "feat(spans): Evict spans during insert (#92393)"** This PR incurred 30% overhead on insert_spans. We only see this reported from the consumer/client -- we don't see additional time spent in redis commands as reported by the cluster itself.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
A proof of concept that limits the number of spans per segment during insertion. Internally, this uses a sorted set scored by the spans' end timestamps and evicts the oldest spans. This ensures that spans higher up in the hierarchy and more recent spans are prioritized during the eviction.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Fixes a regression in #92393, where we changed the type of data in keys without renaming the keys. This PR changes the namespace, which is equivalent to flushing the DB.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
- **Revert "fix(spans): Rename span buf prefix (#92617)"** - **Revert "feat(spans): Evict spans during insert (#92393)"** This PR incurred 30% overhead on insert_spans. We only see this reported from the consumer/client -- we don't see additional time spent in redis commands as reported by the cluster itself.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proof of concept that limits the number of spans per segment during insertion. Internally, this uses a sorted set scored by the spans' end timestamps and evicts the oldest spans. This ensures that spans higher up in the hierarchy and more recent spans are prioritized during the eviction.
Ref VIEPF-15