Skip to content

chore(auto_config): Remove logic for unintended rules #89732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Apr 16, 2025

This has run long enough, and it's run its course.

This was added in #88952 as temporary cleanup code.

This has run long enough and it's run its course.
@armenzg armenzg self-assigned this Apr 16, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2025
@@ -74,15 +73,12 @@ def process_event(

platform = event.platform
assert platform is not None
set_tag("platform", platform)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A drive-by change to improve slicing errors by platform.

@armenzg armenzg marked this pull request as ready for review April 16, 2025 12:56
@armenzg armenzg requested a review from a team as a code owner April 16, 2025 12:56
@armenzg armenzg enabled auto-merge (squash) April 17, 2025 10:20
@armenzg armenzg merged commit 33246e5 into master Apr 17, 2025
64 checks passed
@armenzg armenzg deleted the mark_errors_with_platform/auto_source/armenzg branch April 17, 2025 10:39
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
This has run long enough, and it's run its course.

This was added in #88952 as temporary cleanup code.
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants