Skip to content

fix(auto_source_config): Remove unintended rules #88952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Apr 7, 2025

To keep the project option accurate we will be removing the unintended rules.

armenzg added 6 commits April 4, 2025 10:11
Marking these frames as system will prevent deriving in-app stack trace rules for them.

Using `-app` is not enough to skip the derivation system.

*NOTE*: Some of the modules are still just marked with `-app` and they will be handled in a following PR in order to keep the diff to a minimum
In order to keep the project option accurate we will be removing the unintended rules.
@armenzg armenzg self-assigned this Apr 7, 2025
@armenzg armenzg requested review from a team as code owners April 7, 2025 19:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/issues/auto_source_code_config/task.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88952      +/-   ##
==========================================
+ Coverage   87.69%   87.76%   +0.06%     
==========================================
  Files       10088    10046      -42     
  Lines      570552   569761     -791     
  Branches    22442    22296     -146     
==========================================
- Hits       500367   500032     -335     
+ Misses      69774    69312     -462     
- Partials      411      417       +6     

Base automatically changed from system_frame/rules/armenzg to master April 8, 2025 11:28
@armenzg armenzg enabled auto-merge (squash) April 8, 2025 11:29
@armenzg armenzg merged commit 5631468 into master Apr 8, 2025
48 checks passed
@armenzg armenzg deleted the effects_of_no_framework/auto_source/armenzg branch April 8, 2025 11:58
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
To keep the project option accurate we will be removing the unintended
rules.
Christinarlong pushed a commit that referenced this pull request Apr 10, 2025
To keep the project option accurate we will be removing the unintended
rules.
armenzg added a commit that referenced this pull request Apr 17, 2025
This has run long enough, and it's run its course.

This was added in #88952 as temporary cleanup code.
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
This has run long enough, and it's run its course.

This was added in #88952 as temporary cleanup code.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants