-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(auto_source_config): Remove unintended rules #88952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking these frames as system will prevent deriving in-app stack trace rules for them. Using `-app` is not enough to skip the derivation system. *NOTE*: Some of the modules are still just marked with `-app` and they will be handled in a following PR in order to keep the diff to a minimum
In order to keep the project option accurate we will be removing the unintended rules.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88952 +/- ##
==========================================
+ Coverage 87.69% 87.76% +0.06%
==========================================
Files 10088 10046 -42
Lines 570552 569761 -791
Branches 22442 22296 -146
==========================================
- Hits 500367 500032 -335
+ Misses 69774 69312 -462
- Partials 411 417 +6 |
lobsterkatie
approved these changes
Apr 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
To keep the project option accurate we will be removing the unintended rules.
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
To keep the project option accurate we will be removing the unintended rules.
armenzg
added a commit
that referenced
this pull request
Apr 17, 2025
This has run long enough, and it's run its course. This was added in #88952 as temporary cleanup code.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
This has run long enough, and it's run its course. This was added in #88952 as temporary cleanup code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the project option accurate we will be removing the unintended rules.