Skip to content

fix(autofix): Github links, remove seer branding, and UI cleanup #86640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025
Merged

fix(autofix): Github links, remove seer branding, and UI cleanup #86640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions static/app/components/events/autofix/autofixSolution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,8 @@ const SubmitButton = styled(Button)`
top: 50%;
transform: translateY(-50%);
height: 24px;
width: 24px;
border-radius: 5px;
`;

const AddInstructionWrapper = styled('div')`
Expand Down
7 changes: 3 additions & 4 deletions static/app/views/issueDetails/streamline/sidebar/solutionsHubDrawer.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ describe('SolutionsHubDrawer', () => {

expect(screen.getByText(mockEvent.id)).toBeInTheDocument();

// The heading is "Sentry AI" with a beta badge next to it
expect(screen.getByText('Seer')).toBeInTheDocument();
expect(screen.getByText('Autofix')).toBeInTheDocument();

expect(screen.getByTestId('ai-setup-data-consent')).toBeInTheDocument();
});
Expand All @@ -156,7 +155,7 @@ describe('SolutionsHubDrawer', () => {
screen.queryByTestId('ai-setup-loading-indicator')
);

expect(screen.getByText('Seer')).toBeInTheDocument();
expect(screen.getByText('Autofix')).toBeInTheDocument();

// Verify the Start Autofix button is available
const startButton = screen.getByRole('button', {name: 'Start Autofix'});
Expand Down Expand Up @@ -435,7 +434,7 @@ describe('SolutionsHubDrawer', () => {
screen.queryByTestId('ai-setup-loading-indicator')
);

expect(screen.getByText('Seer')).toBeInTheDocument();
expect(screen.getByText('Autofix')).toBeInTheDocument();

// Since "Install the GitHub Integration" text isn't found, let's check for
// the "Set Up the GitHub Integration" text which is what the component is actually showing
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueDetails/streamline/sidebar/solutionsHubDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export function SolutionsHubDrawer({group, project, event}: SolutionsHubDrawerPr
<SolutionsDrawerNavigator>
<Header>
<SeerIcon size="lg" />
{t('Seer')}
{t('Autofix')}
<StyledFeatureBadge
type="beta"
tooltipProps={{
Expand Down
24 changes: 21 additions & 3 deletions static/app/views/issueDetails/streamline/sidebar/solutionsHubNotices.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,21 @@ describe('SolutionsHubNotices', function () {
);

expect(screen.getByText('Set Up the GitHub Integration')).toBeInTheDocument();

// Test for text fragments with formatting
expect(screen.getByText(/Autofix is/, {exact: false})).toBeInTheDocument();
expect(screen.getByText('a lot better')).toBeInTheDocument();
expect(
screen.getByText(/when it has your codebase as context/, {exact: false})
).toBeInTheDocument();

// Test for text with links
expect(screen.getByText(/Set up the/, {exact: false})).toBeInTheDocument();
expect(screen.getByText('GitHub Integration', {selector: 'a'})).toBeInTheDocument();
expect(
screen.getByText(/to allow Autofix to go deeper/, {exact: false})
).toBeInTheDocument();

expect(screen.getByText('Set Up Now')).toBeInTheDocument();
expect(screen.getByRole('img', {name: 'Install'})).toBeInTheDocument();
});
Expand Down Expand Up @@ -180,12 +195,15 @@ describe('SolutionsHubNotices', function () {
);

const integrationLink = screen.getByText('GitHub integration');
expect(integrationLink).toHaveAttribute('href', '/settings/integrations/github/456');
expect(integrationLink).toHaveAttribute(
'href',
'/settings/org-slug/integrations/github/456'
);

const codeMappingsLink = screen.getByText('code mappings');
expect(codeMappingsLink).toHaveAttribute(
'href',
'/settings/integrations/github/456/?tab=codeMappings'
'/settings/org-slug/integrations/github/456/?tab=codeMappings'
);
});

Expand All @@ -205,7 +223,7 @@ describe('SolutionsHubNotices', function () {
// Should have both the GitHub setup card and the unreadable repos warning
const setupCard = screen.getByText('Set Up the GitHub Integration').closest('div');
const warningAlert = screen
.getByText(/Autofix can't access these repositories/)
.getByText(/Autofix can't access these repositories:/)
.closest('div');

expect(setupCard).toBeInTheDocument();
Expand Down
26 changes: 19 additions & 7 deletions static/app/views/issueDetails/streamline/sidebar/solutionsHubNotices.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,16 @@ import type {AutofixRepository} from 'sentry/components/events/autofix/types';
import ExternalLink from 'sentry/components/links/externalLink';
import {t, tct} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import useOrganization from 'sentry/utils/useOrganization';

interface SolutionsHubNoticesProps {
autofixRepositories: AutofixRepository[];
hasGithubIntegration?: boolean;
}

function GithubIntegrationSetupCard() {
const organization = useOrganization();

return (
<IntegrationCard key="no-readable-repos">
<CardContent>
Expand All @@ -30,12 +33,20 @@ function GithubIntegrationSetupCard() {
{tct(
'Set up the [integrationLink:GitHub Integration] to allow Autofix to go deeper when troubleshooting and fixing your issues–including writing the code and opening PRs.',
{
integrationLink: <ExternalLink href="/settings/integrations/github/" />,
integrationLink: (
<ExternalLink
href={`/settings/${organization.slug}/integrations/github/`}
/>
),
}
)}
</span>
</CardDescription>
<LinkButton href="/settings/integrations/github/" size="sm" priority="primary">
<LinkButton
href={`/settings/${organization.slug}/integrations/github/`}
size="sm"
priority="primary"
>
{t('Set Up Now')}
</LinkButton>
</CardContent>
Expand All @@ -48,6 +59,7 @@ export function SolutionsHubNotices({
autofixRepositories,
hasGithubIntegration,
}: SolutionsHubNoticesProps) {
const organization = useOrganization();
const unreadableRepos = autofixRepositories.filter(repo => repo.is_readable === false);
const notices: JSX.Element[] = [];

Expand Down Expand Up @@ -80,14 +92,14 @@ export function SolutionsHubNotices({
<ExternalLink
href={
integrationId
? `/settings/integrations/github/${integrationId}/`
: '/settings/integrations/github/'
? `/settings/${organization.slug}/integrations/github/${integrationId}/`
: `/settings/${organization.slug}/integrations/github/`
}
/>
),
codeMappingsLink: integrationId ? (
<ExternalLink
href={`/settings/integrations/github/${integrationId}/?tab=codeMappings`}
href={`/settings/${organization.slug}/integrations/github/${integrationId}/?tab=codeMappings`}
/>
) : null,
}
Expand All @@ -113,12 +125,12 @@ export function SolutionsHubNotices({
repo: <b>{unreadableRepo.name}</b>,
integrationLink: (
<ExternalLink
href={`/settings/integrations/github/${unreadableRepo.integration_id}`}
href={`/settings/${organization.slug}/integrations/github/${unreadableRepo.integration_id}`}
/>
),
codeMappingsLink: (
<ExternalLink
href={`/settings/integrations/github/${unreadableRepo.integration_id}/?tab=codeMappings`}
href={`/settings/${organization.slug}/integrations/github/${unreadableRepo.integration_id}/?tab=codeMappings`}
/>
),
}
Expand Down
7 changes: 3 additions & 4 deletions static/app/views/issueDetails/streamline/sidebar/solutionsSection.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ describe('SolutionsSection', () => {
});

describe('Solutions Hub button text', () => {
it('shows "Set Up Seer" when AI needs setup', async () => {
it('shows "Set Up Autofix" when AI needs setup', async () => {
const customOrganization = OrganizationFixture({
genAIConsent: false,
hideAiFeatures: false,
Expand Down Expand Up @@ -235,10 +235,10 @@ describe('SolutionsSection', () => {
});

expect(
screen.getByText('Explore potential root causes and solutions with Seer.')
screen.getByText('Explore potential root causes and solutions with Autofix.')
).toBeInTheDocument();

expect(screen.getByRole('button', {name: 'Set Up Seer'})).toBeInTheDocument();
expect(screen.getByRole('button', {name: 'Set Up Autofix'})).toBeInTheDocument();
});

it('shows "Find Root Cause" even when autofix needs setup', async () => {
Expand Down Expand Up @@ -384,7 +384,6 @@ describe('SolutionsSection', () => {
);

expect(screen.queryByTestId('loading-placeholder')).not.toBeInTheDocument();
expect(screen.queryByRole('button', {name: 'Set Up Seer'})).not.toBeInTheDocument();
expect(
screen.queryByRole('button', {name: 'Set Up Autofix'})
).not.toBeInTheDocument();
Expand Down
4 changes: 3 additions & 1 deletion static/app/views/issueDetails/streamline/sidebar/solutionsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ export default function SolutionsSection({
>
<SolutionsSectionContainer>
{aiConfig.needsGenAIConsent ? (
<Summary>{t('Explore potential root causes and solutions with Seer.')}</Summary>
<Summary>
{t('Explore potential root causes and solutions with Autofix.')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a chance a user sees this on an issue that would have a summary and not autofix, so they set up and then don't see autofix, so technically this might be a problem, but i don't think it's important enough. we'll change this in the future anyway most likely

</Summary>
) : aiConfig.hasAutofix || aiConfig.hasSummary ? (
<SolutionsSectionContent group={group} project={project} event={event} />
) : issueTypeConfig.resources ? (
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueDetails/streamline/sidebar/solutionsSectionCtaButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export function SolutionsSectionCtaButton({

const getButtonText = () => {
if (aiConfig.needsGenAIConsent) {
return t('Set Up Seer');
return t('Set Up Autofix');
}

if (!aiConfig.hasAutofix) {
Expand Down
Loading