Skip to content

fix(profiling) add beta banner ending info #80396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(profiling) add beta banner ending info #80396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions static/app/components/profiling/billing/alerts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {Fragment} from 'react';

import Alert from 'sentry/components/alert';
import {Button} from 'sentry/components/button';
import HookOrDefault from 'sentry/components/hookOrDefault';
import {t} from 'sentry/locale';
Expand All @@ -26,3 +27,13 @@ export const ProfilingAM1OrMMXUpgrade = HookOrDefault({
</Fragment>
),
});

export function ContinuousProfilingBetaBanner() {
return (
<Alert type="warning" showIcon>
{t(
'Continuous Profiling Beta is ending! We will begin to bill you for profiling usage after <date>.'
Copy link
Member Author

@JonasBa JonasBa Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indragiek I just used temporary wording, deferring to you for the exact message that we want here?

)}
</Alert>
);
}
4 changes: 4 additions & 0 deletions static/app/views/profiling/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {PageHeadingQuestionTooltip} from 'sentry/components/pageHeadingQuestionT
import Pagination from 'sentry/components/pagination';
import {TransactionSearchQueryBuilder} from 'sentry/components/performance/transactionSearchQueryBuilder';
import {
ContinuousProfilingBetaBanner,
ProfilingAM1OrMMXUpgrade,
ProfilingBetaAlertBanner,
ProfilingUpgradeButton,
Expand Down Expand Up @@ -358,6 +359,9 @@ function ProfilingContent({location}: ProfilingContentProps) {
>
<Layout.Page>
<ProfilingBetaAlertBanner organization={organization} />
{organization.features.includes('continuous-profiling-beta') ? (
<ContinuousProfilingBetaBanner />
) : null}
<ProfilingContentPageHeader tab={tab} onTabChange={onTabChange} />
{tab === 'flamegraph' ? (
<FlamegraphBody>
Expand Down
Loading