Skip to content

fix(profiling) add beta banner ending info #80396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 7, 2024

Adding a banner for orgs that have been sending us continuous profiles as part of the beta and explain what changes for them

@JonasBa JonasBa requested review from indragiek and Zylphrex November 7, 2024 19:22
@JonasBa JonasBa requested a review from a team as a code owner November 7, 2024 19:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 7, 2024
return (
<Alert type="warning" showIcon>
{t(
'Continuous Profiling Beta is ending! We will begin to bill you for profiling usage after <date>.'
Copy link
Member Author

@JonasBa JonasBa Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indragiek I just used temporary wording, deferring to you for the exact message that we want here?

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
static/app/components/profiling/billing/alerts.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80396      +/-   ##
==========================================
- Coverage   78.31%   78.31%   -0.01%     
==========================================
  Files        7192     7193       +1     
  Lines      318363   318396      +33     
  Branches    43885    43888       +3     
==========================================
+ Hits       249337   249352      +15     
- Misses      62670    62685      +15     
- Partials     6356     6359       +3     

@getsantry
Copy link
Contributor

getsantry bot commented Nov 29, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 29, 2024
@Zylphrex Zylphrex added the WIP label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants