Skip to content

ref(workflow_engine): Drop workflow_engine.workflowaction table #78277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saponifi3d
Copy link
Contributor

Description

Follow up PR for: #78272

Will complete the removal of the table 🎉

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 27, 2024
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0007_loosen_workflow_action_relationship.py src/sentry/workflow_engine/migrations/0008_remove_workflow_action.py ()

--
-- Raw SQL operation
--

            DROP TABLE "workflow_engine_workflowaction";

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78277       +/-   ##
===========================================
+ Coverage   61.67%   78.11%   +16.44%     
===========================================
  Files        7059     7068        +9     
  Lines      311465   311799      +334     
  Branches    50912    50957       +45     
===========================================
+ Hits       192081   243574    +51493     
+ Misses     108141    56466    -51675     
- Partials    11243    11759      +516     

Base automatically changed from jcallender/aci-delete-workflow-actions-1 to master September 27, 2024 20:05
@saponifi3d saponifi3d force-pushed the jcallender/aci-delete-workflow-actions-2 branch from ddbbb65 to 2532aa4 Compare September 27, 2024 20:12
@saponifi3d saponifi3d marked this pull request as ready for review September 27, 2024 20:12
@saponifi3d saponifi3d requested a review from a team as a code owner September 27, 2024 20:12
@saponifi3d
Copy link
Contributor Author

🔒 holding off on merging this until the deploy for the first part is complete (requirement according to https://develop.sentry.dev/development/database-migrations/#deleting-tables)

@saponifi3d saponifi3d requested a review from a team September 27, 2024 20:14
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0008_remove_workflow_action.py ()

--
-- Raw SQL operation
--

            DROP TABLE "workflow_engine_workflowaction";

@getsantry
Copy link
Contributor

getsantry bot commented Oct 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 19, 2024
@saponifi3d saponifi3d added the WIP label Oct 23, 2024
@saponifi3d saponifi3d changed the title Drop workflow_engine.workflowaction table ref(workflow_engine): Drop workflow_engine.workflowaction table Nov 9, 2024
saponifi3d added a commit that referenced this pull request Mar 10, 2025
saponifi3d added a commit that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants