ref(workflow_engine): Finish Removing the legacy fields from Action

[saponifi3d]

Description

Complete the removal of the fields from the action table

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0035_action_model_drop_legacy_fields.py src/sentry/workflow_engine/migrations/0036_action_remove_legacy_fields.py ()

--
-- Remove field target_display from action
--
ALTER TABLE "workflow_engine_action" DROP COLUMN "target_display" CASCADE;
--
-- Remove field target_identifier from action
--
ALTER TABLE "workflow_engine_action" DROP COLUMN "target_identifier" CASCADE;
--
-- Remove field target_type from action
--
ALTER TABLE "workflow_engine_action" DROP COLUMN "target_type" CASCADE;

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #86573      +/-   ##
==========================================
- Coverage   87.79%   87.79%   -0.01%     
==========================================
  Files        9782     9783       +1     
  Lines      554168   554175       +7     
  Branches    21730    21730              
==========================================
+ Hits       486543   486549       +6     
- Misses      67233    67234       +1     
  Partials      392      392              

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0036_action_remove_legacy_fields.py ()

--
-- Remove field target_display from action
--
ALTER TABLE "workflow_engine_action" DROP COLUMN "target_display" CASCADE;
--
-- Remove field target_identifier from action
--
ALTER TABLE "workflow_engine_action" DROP COLUMN "target_identifier" CASCADE;
--
-- Remove field target_type from action
--
ALTER TABLE "workflow_engine_action" DROP COLUMN "target_type" CASCADE;

[ceorourke]

lgtm, double checked against the previous one. won't be offended if you want a migration reviewer's final stamp though