Skip to content

test(sentry10): Update issue detail tests for Sentry 10 #13031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test(sentry10): Update issue detail tests for Sentry 10 #13031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions tests/acceptance/test_issue_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,18 @@ def test_javascript_specific_event(self):
platform='javascript'
)

# Don't enable sentry10 so we have coverage for sentry9 as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep this until we're ready to axe 9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can hold off merging this until the next week or 2. It will be a dependency of #13022 though

self.dismiss_assistant()
self.browser.get(
u'/{}/{}/issues/{}/events/{}/'.format(
self.org.slug,
self.project.slug,
event.group.id,
event.id

with self.feature('organizations:sentry10'):
self.browser.get(
u'/organizations/{}/issues/{}/events/{}/'.format(
self.org.slug,
event.group.id,
event.group.id
)
)
)
self.wait_until_loaded()
self.wait_until_loaded()

self.browser.snapshot('issue details javascript - event details')

self.browser.find_element_by_xpath("//a//code[contains(text(), 'curl')]").click()
Expand Down Expand Up @@ -154,11 +155,13 @@ def test_activity_page(self):
platform='python',
)

self.browser.get(
u'/{}/{}/issues/{}/activity/'.format(
self.org.slug, self.project.slug, event.group.id)
)
self.browser.wait_until('.activity-item')
with self.feature('organizations:sentry10'):
self.browser.get(
u'/organizations/{}/issues/{}/activity/'.format(
self.org.slug, event.group.id)
)
self.browser.wait_until('.activity-item')

self.browser.snapshot('issue activity python')

def wait_until_loaded(self):
Expand Down