test(sentry10): Update issue detail tests for Sentry 10 #13031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update issue details tests for Sentry 10. This will allow mainlining Sentry 10 in future without breaking these tests.
billyvg
reviewed
May 2, 2019
| @@ -83,17 +83,18 @@ def test_javascript_specific_event(self): | |||
| platform='javascript' | |||
| ) | |||
|
|
|||
| # Don't enable sentry10 so we have coverage for sentry9 as well. | |||
There was a problem hiding this comment.
Shouldn't we keep this until we're ready to axe 9?
There was a problem hiding this comment.
We can hold off merging this until the next week or 2. It will be a dependency of #13022 though
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update issue details tests for Sentry 10. This will allow mainlining
Sentry 10 in future without breaking these tests.