Skip to content

ref(scraps): adopt standard backdrop#113968

Merged
natemoo-re merged 10 commits into
masterfrom
nm/scraps/backdrop
Apr 27, 2026
Merged

ref(scraps): adopt standard backdrop#113968
natemoo-re merged 10 commits into
masterfrom
nm/scraps/backdrop

Conversation

@natemoo-re

Copy link
Copy Markdown
Member

This branch eliminates one-off Backdrop components and adopts @sentry/scraps/backdrop around the app.

  • Follow-up to ref(modal): use standard backdrop #113947: reverted because Drawer unintentionally rendered <Backdrop zIndex="modal">
  • Replaces one-off backdrop in new widget builder with backdrop
  • Updates old modal-based widget builder components to use new backdrop

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 24, 2026
@natemoo-re
natemoo-re marked this pull request as ready for review April 27, 2026 14:19
@natemoo-re
natemoo-re requested review from a team as code owners April 27, 2026 14:19
Comment thread static/app/components/globalModal/index.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ca2ae6e9cebd3fed96b4775b9598a6b61cf36a2e. Configure here.

Comment thread static/app/components/globalModal/index.tsx Outdated
Comment thread static/app/components/globalModal/index.tsx
@natemoo-re
natemoo-re enabled auto-merge (squash) April 27, 2026 18:49
@natemoo-re
natemoo-re merged commit 05f2f51 into master Apr 27, 2026
63 of 64 checks passed
@natemoo-re
natemoo-re deleted the nm/scraps/backdrop branch April 27, 2026 18:57
natemoo-re added a commit that referenced this pull request May 1, 2026
Following up on #113489 #113968, this PR moves `GlobalModal` into
Scraps.
- The canonical import is now `@sentry/scraps/modal`.
- The only API change is renaming the hook from `useGlobalModal` ->
`useModal`.

Additional refactors to come.
cleptric pushed a commit that referenced this pull request May 5, 2026
This branch eliminates one-off `Backdrop` components and adopts
`@sentry/scraps/backdrop` around the app.

- Follow-up to #113947: reverted because `Drawer` unintentionally
rendered `<Backdrop zIndex="modal">`
- Replaces one-off backdrop in **new** widget builder with backdrop
- Updates old modal-based widget builder components to use new backdrop
cleptric pushed a commit that referenced this pull request May 5, 2026
Following up on #113489 #113968, this PR moves `GlobalModal` into
Scraps.
- The canonical import is now `@sentry/scraps/modal`.
- The only API change is renaming the hook from `useGlobalModal` ->
`useModal`.

Additional refactors to come.
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants