feat(scraps): adopt GlobalDrawer component into design system#113489
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
natemoo-re
force-pushed
the
nm/ui/drawer
branch
from
April 21, 2026 16:57
a4f8ad2 to
12c11a2
Compare
github-actions
Bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
natemoo-re
force-pushed
the
nm/ui/drawer
branch
from
April 21, 2026 17:06
34f8863 to
1867484
Compare
natemoo-re
marked this pull request as ready for review
April 21, 2026 18:03
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d3bf81ee482168e5c298d1670c3339078b510d7d. Configure here.
natemoo-re
force-pushed
the
nm/ui/drawer
branch
from
April 21, 2026 19:07
22ecdb2 to
fdc98a9
Compare
natemoo-re
removed
the
Scope: Backend
Comment on lines
55
to
62
| openDrawer(() => <SeerDrawer group={group} project={project} event={event} />, { | ||
| ariaLabel: t('Seer drawer'), | ||
| drawerKey: 'seer-autofix-drawer', | ||
| drawerCss: css` | ||
| height: fit-content; | ||
| max-height: 100%; | ||
| `, | ||
| resizable: true, | ||
| closeOnOutsideClick: false, | ||
| shouldLockScroll: false, | ||
| mode: 'passive', | ||
| onClose: () => { | ||
| navigate( | ||
| { |
Contributor
There was a problem hiding this comment.
Bug: The Seer drawer now always renders at full viewport height because the drawerCss prop that set height: fit-content was removed.
Severity: LOW
Suggested Fix
Reintroduce the height: fit-content styling to the Seer drawer. This can be done by applying a style directly to the Drawer component or by using a styled-component wrapper that sets the height appropriately, ensuring it only takes up the space required by its content.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/app/views/issueDetails/streamline/sidebar/seerDrawer.tsx#L55-L62
Potential issue: The Seer drawer component will now always render at the full height of
the viewport, regardless of its content's size. This is because the `drawerCss` prop,
which previously applied `height: fit-content`, was removed during the refactor to use
the `mode: 'passive'` API. The underlying `DrawerSlidePanel` component has a hardcoded
`height: 100%`, and without the `drawerCss` override, this style is now applied, causing
the drawer to occupy the entire screen height instead of fitting its content.
JonasBa
reviewed
Apr 21, 2026
Comment on lines
-58
to
-64
| drawerCss: css` | ||
| height: fit-content; | ||
| max-height: 100%; | ||
| `, | ||
| resizable: true, | ||
| closeOnOutsideClick: false, | ||
| shouldLockScroll: false, |
Contributor
There was a problem hiding this comment.
warms my heart to see all these props removed
JonasBa
approved these changes
Apr 21, 2026
JonasBa
reviewed
Apr 21, 2026
natemoo-re
enabled auto-merge (squash)
April 21, 2026 20:27
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
GlobalDrawerinto@sentry/scraps/drawer. Combines individual boolean options with a singlemode: 'blocking' | 'passive', which is also wired through to theSlideOverPanelprimitive. Removed overrides likedrawerCssandtransitionProps(only used in a few places, not needed).Most file changes here are just updating imports from
sentry/components/globalDrawer/componentsto@sentry/scraps/drawerRecommended review mode: Only files owned by you
Closes DE-1167, DE-1170, DE-1173