Skip to content

Kw/update rn sentry cli commands #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krystofwoldrich merged 5 commits into from
Oct 21, 2022
Merged

Kw/update rn sentry cli commands #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63c87a4
chore(rn): Update RN upload debug symbols command, add include source…
krystofwoldrich Oct 16, 2022
7c432b4
Update include-sources flag
krystofwoldrich Oct 17, 2022
e6703a4
Update changelog
krystofwoldrich Oct 17, 2022
3722b5a
Change to env flag
krystofwoldrich Oct 19, 2022
7bd228b
Update changelog
krystofwoldrich Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- feat(react-native): Xcode plugin debug files upload can include source using env

## 2.2.2

- feat(nextjs): Remove option to auto-wrap data fetchers and API routes (#196)
Expand Down
12 changes: 7 additions & 5 deletions lib/Steps/Integrations/ReactNative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export class ReactNative extends MobileProject {

private _addNewXcodeBuildPhaseForSymbols(buildScripts: any, proj: any): void {
for (const script of buildScripts) {
if (script.shellScript.match(/sentry-cli\s+upload-dsym/)) {
if (script.shellScript.match(/sentry-cli\s+(upload-dsym|debug-files upload)/)) {
return;
}
}
Expand All @@ -279,9 +279,11 @@ export class ReactNative extends MobileProject {
null,
{
shellPath: '/bin/sh',
shellScript:
'export SENTRY_PROPERTIES=sentry.properties\\n' +
'../node_modules/@sentry/cli/bin/sentry-cli upload-dsym',
shellScript:`
export SENTRY_PROPERTIES=sentry.properties
[[ $SENTRY_INCLUDE_NATIVE_SOURCES == "true" ]] && INCLUDE_SOURCES_FLAG="--include-sources" || INCLUDE_SOURCES_FLAG=""
../node_modules/@sentry/cli/bin/sentry-cli debug-files upload "$INCLUDE_SOURCES_FLAG"
`,
},
);
}
Expand Down Expand Up @@ -382,7 +384,7 @@ export class ReactNative extends MobileProject {

if (
script.shellScript.match(
/@sentry\/cli\/bin\/sentry-cli\s+upload-dsym\b/,
/@sentry\/cli\/bin\/sentry-cli\s+(upload-dsym|debug-files upload)\b/,
)
) {
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
Expand Down