Skip to content

Kw/update rn sentry cli commands #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krystofwoldrich merged 5 commits into from
Oct 21, 2022
Merged

Kw/update rn sentry cli commands #199

krystofwoldrich merged 5 commits into from
Oct 21, 2022

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Oct 17, 2022 •
edited
Loading

Closes: #181

Relates to CLI update in RN SDK getsentry/sentry-react-native#2246 and getsentry/sentry-react-native#2457

@krystofwoldrich krystofwoldrich mentioned this pull request Oct 17, 2022
Merged
@krystofwoldrich
Copy link
Contributor Author

krystofwoldrich commented Oct 17, 2022

The sentry.properties file in ios dir would like like this:

debug_files.upload.include_sources=true

marandaneto
marandaneto reviewed Oct 17, 2022
View reviewed changes
@krystofwoldrich
Copy link
Contributor Author

krystofwoldrich commented Oct 19, 2022

I've simplified this to env SENTRY_INCLUDE_NATIVE_SOURCES. This way it should be simple enough to opt-in for the feature and it won't affect the cli properties file.

marandaneto
marandaneto reviewed Oct 19, 2022
View reviewed changes
@marandaneto
Copy link
Contributor

marandaneto commented Oct 19, 2022

We can specify this on the docs as well https://docs.sentry.io/platforms/react-native/upload-debug/
How to export the var or add it manually via the UI on Xcode.

@krystofwoldrich krystofwoldrich merged commit f4b164a into master Oct 21, 2022
@krystofwoldrich krystofwoldrich deleted the kw/update-rn-sentry-cli-commands branch October 21, 2022 13:54
@krystofwoldrich krystofwoldrich mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marandaneto marandaneto marandaneto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace deprecated upload-dsym for RN-iOS and add support for the new one

3 participants

@krystofwoldrich @marandaneto