This repository was archived by the owner on Nov 20, 2023. It is now read-only.
fix(types): Switch compilation type in error handler to unknown
#322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two years ago, we modified the
errorHandleroption to take a third argument, of the typeCompilation. Though the contents of the type exists in similar forms in webpack 4 and 5, in webpack 4 it's exported ascompilation.Compilation, where as in webpack 5, it's exported at the top-level.This didn't matter much until about a month ago, when #308 updated the overall options type to reflect the addition of the third argument for
errorHandler. That change was released three days ago, in v 1.17.2. Because that PR usedCompilationin its webpack 5/top-level form, anyone using this plugin together with webpack 4 and TS will receive the following error when they import the plugin (assuming they haveskipLibCheckset tofalsein their TS config):This fixes that by using
unknownas the type instead, and updates the docstring with a note about the above. It also changes the dev dependencies forwebpackand@types/webpack. Even though the new version requirements will always result in 5.x getting installed, keeping the 4.41.31 entry is a reminder to anyone reading the file that a) we should preserve compatibility with 4.x, and b) that that's the minimum 4.x version we need to worry about (see here).Fixes #321.