This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Fix types of SentryCliPluginOptions.errorHandler #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3rd argument is optional, so it should have sentry-webpack-plugin/src/index.js Lines 390 to 391 in 1adcc72 |
@kamilogorek is the third argument optional to use or really may be not passed? |
|
Ah, you are right. It's optional to use, not optional to be available. Thanks! :) |
kamilogorek
approved these changes
Sep 1, 2021
This was referenced Oct 7, 2021
lobsterkatie
added a commit
that referenced
this pull request
Oct 7, 2021
Two years ago, in #155, we modified the `errorHandler` option to take a third argument, of the type `Compilation`. Though the _contents_ of the type exists in similar forms in webpack 4 and 5, in webpack 4[1] it's exported as `compilation.Compilation`, where as in webpack 5[2], it's exported at the top-level. This didn't matter much until about a month ago, when #308 updated the overall options type to reflect the addition of the third argument for `errorHandler`. That change was released in v 1.17.2. Because that PR used `Compilation` in its webpack 5/top-level form, anyone using this plugin together with webpack 4 and TS will receive the a compilation error when they import the plugin (assuming they have `skipLibCheck` set to `false` in their TS config). This fixes that by using `unknown` as the type instead, and updates the docstring with a note about the above. It also changes the dev dependencies for `webpack` and `@types/webpack`. Even though the new version requirements will always result in 5.x getting installed, keeping the 4.41.31 entry is a reminder to anyone reading the file that a) we should preserve compatibility with 4.x, and b) that that's the minimum 4.x version we need to worry about (see #296 (comment)). Fixes #321. [1] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/2ab8f4dea373a70d377549a97c0c36807f5a8151/types/webpack/v4/index.d.ts#L1288 [2] https://github.com/webpack/webpack/blob/da74127bfeacff017c5d60842351b4136afba794/types.d.ts#L1297
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to documentation in
readme.md