Skip to content

chore(deps): bump anyhow and disable its backtrace feature #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LunaBorowska
Copy link
Contributor

@LunaBorowska LunaBorowska commented Dec 27, 2023

Since anyhow 1.0.77, backtrace feature is not needed for Rust 1.65+ (https://github.com/dtolnay/anyhow/releases/tag/1.0.77). Because sentry has a higher MSRV than that, it's no longer necessary to enable this feature.

@LunaBorowska LunaBorowska force-pushed the avoid-downloading-anyhow-backtrace-dependency branch 2 times, most recently from d7a807d to 7687a7a Compare December 27, 2023 12:53
@Swatinem
Copy link
Member

It might not be necessary, but I doubt it hurts to keep it?

I would have to take a closer look at this in any case.

LunaBorowska and others added 3 commits June 20, 2025 11:53
Since anyhow 1.0.77, backtrace feature is not needed for
Rust 1.65+ (https://github.com/dtolnay/anyhow/releases/tag/1.0.77).
Because sentry has a higher MSRV than that, it's no longer necessary
to enable this feature.
@lcian lcian force-pushed the avoid-downloading-anyhow-backtrace-dependency branch from 7687a7a to 3a60513 Compare June 20, 2025 12:22
@lcian lcian changed the title ref(anyhow): Disable anyhow's backtrace feature chore(deps): bump anyhow and disable its backtrace feature Jun 20, 2025
@lcian
Copy link
Member

lcian commented Jun 20, 2025

This is legit, also we need to bump anyhow to at least this version due to the changes introduced in #759 which rely on it.
At the moment, if someone has a too low version of anyhow in their lockfile, sentry-anyhow will fail to compile.

error[E0599]: no method named `status` found for reference `&impl std::fmt::Debug + std::fmt::Display` in the current scope
  --> /Users/lcian/repos/sentry-rust/sentry-anyhow/src/lib.rs:76:27
   |
76 |                 backtrace.status(),
   |                           ^^^^^^ method not found in `&impl Debug + Display`

sentry-anyhow on its own compiles fine because we have 1.0.98 in the lockfile of this repo.

@lcian lcian requested a review from Swatinem June 20, 2025 14:45
@lcian lcian merged commit 3a18382 into getsentry:master Jun 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants