fix(anyhow): attach stacktrace only if anyhow error has backtrace #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #755 but for the anyhow integration
Without this change, if we're running without
RUST_BACKTRACE
set, thenbacktrace
will have value"<disabled>"
.We would try to parse it and get an empty vec as a result.
The consequence is that all anyhows would be grouped in a single issue due to having the same (empty) stack trace.
After the change, there will be no stack trace, so grouping will happen according to the error message.
Side effect: when running with
attach_stacktrace: true
,sentry-backtrace
will kick in and provide a backtrace (this didn't happen before because we had a stack trace, even though it was an empty one).It could be argued whether we want this or not.
Closes #745