Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Oct 14, 2025

📜 Description

  • Move senry-cocoa enableLogs out of experimental

💡 Motivation and Context

Branches from #5153 so coco CI is happy.
Relates to getsentry/sentry-cocoa#6359

This can only be merged once #5153 is merged and sentry-cocoa v9 is released.

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Move `sentry-cocoa` `enableLogs` out of experimental ([#5267](https://github.com/getsentry/sentry-react-native/pull/5267))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against b0d50e5

@denrase denrase changed the title Denrase/options enable logs Move senry-cocoa enableLogs out of experimental Oct 14, 2025
@denrase denrase changed the title Move senry-cocoa enableLogs out of experimental Move sentry-cocoa enableLogs out of experimental Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.18 ms 435.34 ms 32.16 ms
Size 17.75 MiB 19.70 MiB 1.95 MiB

Baseline results on branch: itay/fix_sentreyscreenframes

Startup times

Revision Plain With Sentry Diff
ede2a89 414.58 ms 395.16 ms -19.42 ms
3a9200e+dirty 451.42 ms 481.13 ms 29.71 ms

App size

Revision Plain With Sentry Diff
ede2a89 17.75 MiB 19.68 MiB 1.94 MiB
3a9200e+dirty 17.75 MiB 19.70 MiB 1.95 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 304.77 ms 311.36 ms 6.59 ms
Size 7.15 MiB 8.43 MiB 1.28 MiB

Baseline results on branch: itay/fix_sentreyscreenframes

Startup times

Revision Plain With Sentry Diff
3a9200e+dirty 341.91 ms 405.08 ms 63.17 ms
ede2a89+dirty 398.04 ms 486.04 ms 88.00 ms

App size

Revision Plain With Sentry Diff
3a9200e+dirty 7.15 MiB 8.43 MiB 1.28 MiB
ede2a89+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@denrase denrase changed the base branch from main to itay/fix_sentreyscreenframes October 14, 2025 15:03
@antonis antonis mentioned this pull request Nov 11, 2025
10 tasks
Base automatically changed from itay/fix_sentreyscreenframes to cocoa-v9 November 11, 2025 15:38
@antonis antonis marked this pull request as ready for review November 11, 2025 15:39
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
I'll proceed with merging in cocoa-v9

@antonis antonis merged commit 63f29e8 into cocoa-v9 Nov 11, 2025
1 check passed
@antonis antonis deleted the denrase/options-enable-logs branch November 11, 2025 15:39
antonis added a commit that referenced this pull request Dec 23, 2025
* chore(deps): update Cocoa SDK to v9.0.0-alpha.0

* Adds changelog

* fix: Fixes SentryScreenFrames use after being converted to Swift (#5153)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>

* Move `sentry-cocoa` `enableLogs` out of experimental (#5267)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>

* chore: Remove SentryFrameTracker imports (#5276)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>

* fix(podspec): Cocoa V9 allow any alpha version

* chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 (#5359)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 (#5369)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0

* Bump to 15.1 due to RN 0.81.0 requirements

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>

* chore(ci): Cocoa V9: Run the full CI checks for cocoa-v9 (#5370)

* Update changelog

* Bumpt to RC1

* Remove cocoa-v9 from ci branches

* fix: Use new session replay name for hybrid SDK

* Fix rename

* chore(lint): Fixes lint issues

* Update changelog to GA

* Update changelog

* Bump minimum to 9.1.0

* Set Cocoa version to 9.1.0

---------

Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrašec <denrase@gmail.com>
Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Noah Martin <noahm444@gmail.com>
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants