fix: Fixes SentryScreenFrames use after being converted to Swift #5153

itaybre · 2025-09-08T18:28:11Z

Fixes SentryScreenFrames converted to swift in getsentry/sentry-cocoa#6094

#skip-changelog

github-actions · 2025-09-08T18:42:51Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	424.76 ms	430.42 ms	5.66 ms
Size	17.75 MiB	19.70 MiB	1.96 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d751a5d`+dirty	434.24 ms	486.08 ms	51.84 ms
`46da307`	455.92 ms	443.79 ms	-12.13 ms
`459a438`+dirty	417.09 ms	406.52 ms	-10.57 ms
`90afdd3`+dirty	375.94 ms	377.52 ms	1.58 ms
`c7f264b`	434.98 ms	452.96 ms	17.98 ms
`ba75c7c`	367.72 ms	369.16 ms	1.44 ms
`5c16cdc`+dirty	423.48 ms	452.35 ms	28.88 ms
`7480abe`+dirty	411.60 ms	405.81 ms	-5.78 ms
`b3b5b0d`	399.82 ms	419.20 ms	19.38 ms
`eb07ba3`	470.04 ms	473.35 ms	3.31 ms

App size

Revision	Plain	With Sentry	Diff
`d751a5d`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`46da307`	17.75 MiB	19.68 MiB	1.93 MiB
`459a438`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`90afdd3`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`c7f264b`	17.75 MiB	19.68 MiB	1.94 MiB
`ba75c7c`	17.75 MiB	20.15 MiB	2.41 MiB
`5c16cdc`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`7480abe`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`b3b5b0d`	17.75 MiB	19.68 MiB	1.94 MiB
`eb07ba3`	17.75 MiB	20.15 MiB	2.41 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision	Plain	With Sentry	Diff
`ede2a89`	414.58 ms	395.16 ms	-19.42 ms
`3a9200e`+dirty	451.42 ms	481.13 ms	29.71 ms

App size

Revision	Plain	With Sentry	Diff
`ede2a89`	17.75 MiB	19.68 MiB	1.94 MiB
`3a9200e`+dirty	17.75 MiB	19.70 MiB	1.95 MiB

github-actions · 2025-09-08T18:54:31Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.14 ms	1223.55 ms	1.41 ms
Size	2.63 MiB	4.00 MiB	1.36 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`bc9680d`+dirty	1221.41 ms	1241.47 ms	20.06 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`b3b5b0d`+dirty	1227.71 ms	1239.50 ms	11.79 ms
`c9e95bd`+dirty	1240.19 ms	1246.33 ms	6.14 ms
`c1573b3`+dirty	1203.33 ms	1202.47 ms	-0.86 ms
`59f3a84`+dirty	1232.56 ms	1238.12 ms	5.56 ms
`8a4ce6f`+dirty	1221.31 ms	1219.84 ms	-1.47 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`9f211e3`+dirty	1218.80 ms	1233.88 ms	15.08 ms
`d751a5d`+dirty	1215.57 ms	1220.56 ms	4.99 ms

App size

Revision	Plain	With Sentry	Diff
`bc9680d`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`b3b5b0d`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`c9e95bd`+dirty	2.63 MiB	3.87 MiB	1.24 MiB
`c1573b3`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`59f3a84`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a4ce6f`+dirty	2.63 MiB	3.96 MiB	1.33 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`9f211e3`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`d751a5d`+dirty	2.63 MiB	3.98 MiB	1.34 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision	Plain	With Sentry	Diff
`ede2a89`+dirty	1218.37 ms	1224.38 ms	6.01 ms
`3a9200e`+dirty	1220.31 ms	1234.48 ms	14.17 ms

App size

Revision	Plain	With Sentry	Diff
`ede2a89`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`3a9200e`+dirty	2.63 MiB	3.99 MiB	1.36 MiB

github-actions · 2025-09-08T18:54:44Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	283.51 ms	310.22 ms	26.71 ms
Size	7.15 MiB	8.43 MiB	1.28 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`785ffb1`+dirty	380.65 ms	451.83 ms	71.18 ms
`1853710`+dirty	360.67 ms	396.28 ms	35.61 ms
`c7f264b`+dirty	356.98 ms	407.46 ms	50.48 ms
`a2bb688`+dirty	371.19 ms	389.18 ms	17.99 ms
`d1fd647`+dirty	374.46 ms	409.51 ms	35.05 ms
`20d5eaa`+dirty	358.31 ms	442.37 ms	84.06 ms
`0b64753`+dirty	358.55 ms	429.16 ms	70.61 ms
`23080e5`+dirty	347.29 ms	381.87 ms	34.58 ms
`af9331b`+dirty	374.42 ms	425.68 ms	51.26 ms
`3e0a5f9`+dirty	379.92 ms	450.96 ms	71.04 ms

App size

Revision	Plain	With Sentry	Diff
`785ffb1`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`1853710`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c7f264b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`a2bb688`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`d1fd647`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`20d5eaa`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`0b64753`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`23080e5`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`af9331b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`3e0a5f9`+dirty	7.15 MiB	8.42 MiB	1.27 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision	Plain	With Sentry	Diff
`ede2a89`+dirty	398.04 ms	486.04 ms	88.00 ms
`3a9200e`+dirty	341.91 ms	405.08 ms	63.17 ms

App size

Revision	Plain	With Sentry	Diff
`ede2a89`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`3a9200e`+dirty	7.15 MiB	8.43 MiB	1.28 MiB

github-actions · 2025-09-08T18:57:56Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1231.41 ms	1246.84 ms	15.43 ms
Size	3.19 MiB	4.56 MiB	1.38 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`bc9680d`+dirty	1228.57 ms	1233.64 ms	5.07 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`b3b5b0d`+dirty	1235.16 ms	1238.61 ms	3.45 ms
`c9e95bd`+dirty	1205.83 ms	1207.38 ms	1.55 ms
`c1573b3`+dirty	1245.69 ms	1245.48 ms	-0.21 ms
`59f3a84`+dirty	1205.09 ms	1213.31 ms	8.23 ms
`8a4ce6f`+dirty	1232.80 ms	1223.80 ms	-9.00 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms
`9f211e3`+dirty	1215.38 ms	1218.15 ms	2.77 ms
`d751a5d`+dirty	1212.22 ms	1217.94 ms	5.71 ms

App size

Revision	Plain	With Sentry	Diff
`bc9680d`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`b3b5b0d`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`c9e95bd`+dirty	3.19 MiB	4.44 MiB	1.25 MiB
`c1573b3`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`59f3a84`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`8a4ce6f`+dirty	3.19 MiB	4.53 MiB	1.34 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`9f211e3`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`d751a5d`+dirty	3.19 MiB	4.54 MiB	1.36 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision	Plain	With Sentry	Diff
`ede2a89`+dirty	1229.10 ms	1227.88 ms	-1.23 ms
`3a9200e`+dirty	1226.94 ms	1239.00 ms	12.06 ms

App size

Revision	Plain	With Sentry	Diff
`ede2a89`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`3a9200e`+dirty	3.19 MiB	4.56 MiB	1.37 MiB

antonis · 2025-09-09T07:46:29Z

Thank you for opening this ahead of the changes Itay. The changes LGTM.
I'll keep this blocked till the changes land with the next version of Cocoa.

packages/core/ios/SentryScreenFramesWrapper.m

itaybre · 2025-10-03T18:31:51Z

Already merged on sentry-cocoa, ready to merge the fix.

antonis · 2025-10-06T09:01:10Z

Thank you for the heads up Itay 🙇

Already merged on sentry-cocoa, ready to merge the fix.

Noting this to merge along the next Cocoa pump 📓

antonis · 2025-10-14T11:43:58Z

@itaybre My understanding is that the changes of getsentry/sentry-cocoa#6094 were merged on main and would be released with v9. They are not part of 8.57.0. Correct?

denrase · 2025-10-14T14:09:35Z

@itaybre FYI, I created a PR based on this one, as we also need to update the enableLogs option, as we'll move it out of experimental for v9. We should sync how to best unify this once v9 is released.

itaybre · 2025-10-17T17:46:38Z

@itaybre FYI, I created a PR based on this one, as we also need to update the enableLogs option, as we'll move it out of experimental for v9. We should sync how to best unify this once v9 is released.

Sounds good, I had to do the same again with another PR.

@itaybre My understanding is that the changes of getsentry/sentry-cocoa#6094 were merged on main and would be released with v9. They are not part of 8.57.0. Correct?

Correct

# Conflicts: # packages/core/ios/RNSentry.mm

antonis

LGTM 🚀
I'll proceed with merging in cocoa-v9

* chore(deps): update Cocoa SDK to v9.0.0-alpha.0 * Adds changelog * fix: Fixes SentryScreenFrames use after being converted to Swift (#5153) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> * Move `sentry-cocoa` `enableLogs` out of experimental (#5267) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> * chore: Remove SentryFrameTracker imports (#5276) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> * fix(podspec): Cocoa V9 allow any alpha version * chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 (#5359) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 (#5369) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 * Bump to 15.1 due to RN 0.81.0 requirements --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> * chore(ci): Cocoa V9: Run the full CI checks for cocoa-v9 (#5370) * Update changelog * Bumpt to RC1 * Remove cocoa-v9 from ci branches * fix: Use new session replay name for hybrid SDK * Fix rename * chore(lint): Fixes lint issues * Update changelog to GA * Update changelog * Bump minimum to 9.1.0 * Set Cocoa version to 9.1.0 --------- Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrašec <denrase@gmail.com> Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Noah Martin <noahm444@gmail.com> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>

fix: Fixes SentryScreenFrames use after being converted to Swift

686b6f8

itaybre requested review from alwx, antonis and lucas-zimerman as code owners September 8, 2025 18:28

itaybre mentioned this pull request Sep 8, 2025

Convert SentryScreenFrames to Swift getsentry/sentry-cocoa#6094

Merged

antonis added the Blocked label Sep 9, 2025

lucas-zimerman reviewed Sep 9, 2025

View reviewed changes

packages/core/ios/SentryScreenFramesWrapper.m Show resolved Hide resolved

itaybre and others added 2 commits October 3, 2025 13:45

Merge branch 'main' into itay/fix_sentreyscreenframes

07104dd

Fix build

5a09e8e

Merge branch 'main' into itay/fix_sentreyscreenframes

347a601

denrase mentioned this pull request Oct 14, 2025

Move sentry-cocoa enableLogs out of experimental #5267

Merged

6 tasks

antonis mentioned this pull request Oct 16, 2025

Verify compatibility with with Cocoa V9 (Ongoing) #5273

Closed

Merge branch 'main' into itay/fix_sentreyscreenframes

2b4c1d4

itaybre mentioned this pull request Oct 17, 2025

chore: Remove SentryFrameTracker imports #5276

Merged

Merge branch 'cocoa-v9' into itay/fix_sentreyscreenframes

914e943

# Conflicts: # packages/core/ios/RNSentry.mm

antonis changed the base branch from main to cocoa-v9 November 11, 2025 13:49

antonis mentioned this pull request Nov 11, 2025

chore(deps): update Cocoa SDK to v9 #5356

Merged

10 tasks

antonis approved these changes Nov 11, 2025

View reviewed changes

antonis merged commit 4806cf2 into cocoa-v9 Nov 11, 2025
33 of 37 checks passed

antonis deleted the itay/fix_sentreyscreenframes branch November 11, 2025 15:38

Uh oh!

fix: Fixes SentryScreenFrames use after being converted to Swift #5153

fix: Fixes SentryScreenFrames use after being converted to Swift #5153

Uh oh!

Conversation

itaybre commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

App size

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

App size

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

App size

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

App size

Uh oh!

antonis commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

itaybre commented Oct 3, 2025

Uh oh!

antonis commented Oct 6, 2025

Uh oh!

antonis commented Oct 14, 2025

Uh oh!

denrase commented Oct 14, 2025

Uh oh!

itaybre commented Oct 17, 2025

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

itaybre commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

antonis commented Sep 9, 2025 •

edited

Loading