Skip to content

fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 4 commits into from
Jul 11, 2025
Merged

fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump #4988

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a995573
chore: update scripts/update-cocoa.sh to 8.53.2
web-flow Jul 10, 2025
3e7af65
fix(session-replay): fixes navigation breadcrumb filtering after Coco…
antonis Jul 10, 2025
995ea24
Merge branch 'deps/scripts/update-cocoa.sh' into antonis/cocoa-8.53.2…
antonis Jul 10, 2025
ee74808
Remove duplicate changelog entry after merge
antonis Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions packages/core/ios/RNSentryReplayBreadcrumbConverter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,23 @@ - (instancetype _Nonnull)init
SentryRRWebEvent *nativeBreadcrumb = [self->defaultConverter convertFrom:breadcrumb];

// ignore native navigation breadcrumbs
if (nativeBreadcrumb && nativeBreadcrumb.data && nativeBreadcrumb.data[@"payload"]
&& nativeBreadcrumb.data[@"payload"][@"category"] &&
[nativeBreadcrumb.data[@"payload"][@"category"] isEqualToString:@"navigation"]) {
return nil;
if (nativeBreadcrumb) {
@try {
id data = [nativeBreadcrumb valueForKey:@"data"];
if (data && [data isKindOfClass:[NSDictionary class]]) {
NSDictionary *dataDict = (NSDictionary *)data;
id payload = dataDict[@"payload"];
if (payload && [payload isKindOfClass:[NSDictionary class]]) {
NSDictionary *payloadDict = (NSDictionary *)payload;
NSString *category = payloadDict[@"category"];
if ([category isEqualToString:@"navigation"]) {
return nil;
}
}
}
} @catch (NSException *exception) {
// Just continue without ignoring native navigation breadcrumbs
}
}

return nativeBreadcrumb;
Expand Down
Loading