Skip to content

ref: Emit transaction instead of culprit #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2018
Merged

ref: Emit transaction instead of culprit #408

merged 1 commit into from
May 15, 2018

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer requested a review from HazAT as a code owner May 15, 2018 09:08
@jan-auer jan-auer self-assigned this May 15, 2018
HazAT
HazAT approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we also need to update raven-js because we don't create any event here, everything comes from raven-js or sentry-cocoa.

@jan-auer jan-auer merged commit 868fafe into master May 15, 2018
@jan-auer jan-auer deleted the ref/transaction branch May 15, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @HazAT