ref: Emit transaction instead of culprit #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
May 15, 2018
| ? global | ||
| : typeof self !== 'undefined' | ||
| ? self | ||
| : {}; |
|
Hey @jan-auer @kamilogorek , just wondering what is the difference between culprit and transaction. I'm still using 0.36 (version used by Expo) and started to see long absolute and unhelpful culprit urls. Will upgrading fix this issue? This seems related to what is reported here: #1400 |
|
The "culprit" is just a leftover from an old, old API. It's always called transaction now. Excuse me such a long response time, was on vacations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we emit a
transactionnow instead of the culprit. In ReactNative,we still normalize both, depending on what the user has set.