fix: don't fail crashpad startup on invalid DSN

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Reject invalid trace- and span-ids in context update from header ([#1046](https://github.com/getsentry/sentry-native/pull/1046))
 - Lookup `GetSystemTimePreciseAsFileTime()` at runtime and fall back to `GetSystemTimeAsFileTime()` to allow running on Windows < 8. ([#1051](https://github.com/getsentry/sentry-native/pull/1051))
+- Allow for empty DSN to still initialize crash handler ([#1059](https://github.com/getsentry/sentry-native/pull/1059))
 
 ## 0.7.10
 

src/backends/sentry_backend_crashpad.cpp

@@ -434,23 +434,17 @@ crashpad_backend_startup(
     // `sentry_init` will persist the upload flag.
     data->db = crashpad::CrashReportDatabase::Initialize(database).release();
     data->client = new crashpad::CrashpadClient;
-    bool success;
     char *minidump_url
         = sentry__dsn_get_minidump_url(options->dsn, options->user_agent);
     if (minidump_url) {
         SENTRY_TRACEF("using minidump URL \"%s\"", minidump_url);
-        success = data->client->StartHandler(handler, database, database,
-            minidump_url, options->http_proxy ? options->http_proxy : "",
-            annotations, arguments,
-            /* restartable */ true,
-            /* asynchronous_start */ false, attachments);
-        sentry_free(minidump_url);
-    } else {
-        SENTRY_WARN(
-            "failed to construct minidump URL (check DSN or user-agent)");
-        crashpad_state_dtor(data);
-        return 1;
     }
+    bool success = data->client->StartHandler(handler, database, database,
+        minidump_url ? minidump_url : "",
+        options->http_proxy ? options->http_proxy : "", annotations, arguments,
+        /* restartable */ true,
+        /* asynchronous_start */ false, attachments);
+    sentry_free(minidump_url);
 
 #ifdef SENTRY_PLATFORM_WINDOWS
     crashpad_register_wer_module(absolute_handler_path, data);