fix: don't fail crashpad startup on invalid DSN
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 81.80% 82.62% +0.82%
==========================================
Files 53 53
Lines 6363 7656 +1293
Branches 1207 1208 +1
==========================================
+ Hits 5205 6326 +1121
- Misses 1046 1216 +170
- Partials 112 114 +2 |
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
|
Btw, this should end up in the change log as a fix. |
supervacuus
changed the title
crashpad startup on invalid DSN
supervacuus
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1056
When leaving the DSN empty, the crashpad handler wouldn't start. This PR fixes this by warning the user about the empty DSN and not failing the initialization anymore.