fix(transactions): Remove some stuff Snuba doesn't care about #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to be overly strict. If no consumer requires some invariant we are not going to enforce it here. There's a lot more that can be loosened here, this is just some stuff I saw regularly happenening today.
|
This pull request contains the following schema changes # schemas/transactions.v1.schema.json
There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.
This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out? |
untitaker
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to be overly strict. If no consumer requires some invariant we are not going to enforce it here.
There's a lot more that can be loosened here, this is just some stuff I saw regularly happenening today.