Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Rewrite the crate and add support for references #10

Merged
merged 3 commits into from
Apr 7, 2023
Merged

ref: Rewrite the crate and add support for references #10

merged 3 commits into from
Apr 7, 2023

Conversation

untitaker
Copy link
Member

  • get rid of internal AST, restructure code a bit
  • add better support for definitions

@untitaker untitaker requested a review from a team as a code owner April 7, 2023 15:27
@untitaker
Copy link
Member Author

This should fix the diff in https://github.com/getsentry/sentry-kafka-schemas/pull/98 and getsentry/sentry-kafka-schemas#99

lynnagara
lynnagara approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I didn't read it all but generally lgtm

@untitaker untitaker merged commit 259b70a into main Apr 7, 2023
@untitaker untitaker deleted the ref/rewrite branch April 7, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynnagara lynnagara lynnagara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @lynnagara