Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): Add assets option to source maps upload options #9668

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 27, 2023

This PR adds the assets option to the Astro integration source maps upload options.

It behaves just like the assets option of the Vite plugin, taking a (array of) glob(s) and overriding the
default values.
This came up in #9591 and I think it makes sense to give users with more advanced/custom setups the ability to
override our defaults.

Docs PR: getsentry/sentry-docs#8586

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No direct exporting of API 👌😄

@Lms24
Copy link
Member Author

Lms24 commented Nov 27, 2023

No direct exporting of API 👌😄

Never again ;)

Copy link
Contributor

github-actions bot commented Nov 27, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.86 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.46 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (0%)
@sentry/browser - Webpack (gzipped) 21.38 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.71 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.6 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.46 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.32 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.29 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.21 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.24 KB (0%)
@sentry/react - Webpack (gzipped) 21.42 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (0%)

@Lms24 Lms24 force-pushed the lms/feat-astro-assets-option branch from 8f4b2d4 to 0a82e21 Compare November 28, 2023 08:16
@Lms24 Lms24 merged commit 16e5037 into develop Nov 28, 2023
49 checks passed
@Lms24 Lms24 deleted the lms/feat-astro-assets-option branch November 28, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants