fix(astro): Configure default sourcemap assets glob for Vercel adapter #9665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Nov 27, 2023
Lms24
force-pushed
the
lms/fix-astro-vercel-sourcemaps
branch
from
c580cd2 to
0303ac4
Compare
size-limit report 📦
|
anonrig
reviewed
Nov 27, 2023
| // only copied over to <root>/.vercel. This seems to happen too late though. | ||
| // So we glob on both of these directories. | ||
| // Another case of "it ain't pretty but it works":( | ||
| if (config.adapter && config.adapter.name?.startsWith('@astrojs/vercel')) { |
There was a problem hiding this comment.
Suggested change
| if (config.adapter && config.adapter.name?.startsWith('@astrojs/vercel')) { | |
| if (config.adapter?.name?.startsWith('@astrojs/vercel')) { |
There was a problem hiding this comment.
Whoops, good catch, just saw it too late. Will sneak your suggestion into #9668
Lms24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for uploading sourcemaps when using the
@astrojs/vercel/*adapters.It seems that the adapter updates the config.outdir value too late for our previous detection logic to
correctly detect the .vercel output directory. Furthermore, the adapter for some reason first saves server
files to /dist only to copy it later to /.vercel/functions. This copy command seems to happen too
late for when our sourcemaps plugin runs.
For these two reasons, we try to detect the used adapter (love that this is much simpler in Astro than
Sveltekit) and adjust the assets glob to search for files in both,
distand.vercel.Tested this for client side (island) and server-side errors with a test app deployed to vercel (serverless, not
edge) and it seems to work well.
Note: I'll open a separate PR for users to specify a custom assets glob for more advanced setups.
closes #9591