Fix stacks including Firefox resource: URLs (#836) #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@dmose Thanks for the contribution. Will review. |
benvinegar
approved these changes
Jan 23, 2017
| This was originally forked from github.com/occ/TraceKit, but has since been | ||
| largely re-written and is now maintained as part of raven-js. Tests for | ||
| this are in test/vendor. |
Contributor
Author
There was a problem hiding this comment.
:-) Yeah, it took me a while to figure out where I needed to patch the code, so I figured I'd try and save future new contribs the same pain.
Contributor
Author
|
Thanks for the quick turnaround on the merge, BTW! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TraceKit parser to generate full stacks even when resource: URLs are part of the stack.