Update Angular error regex to work w/ minified exceptions (fixes #606) #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| // See https://github.com/angular/angular.js/blob/v1.4.7/src/minErr.js | |||
| var angularPattern = /^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.+?)\n(\S+)$/; | |||
| var angularPattern = /^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.*?)\n?(\S+)$/; | |||
There was a problem hiding this comment.
? is the only meaningful change here, isn't it? Changes in data callback are only refactoring
There was a problem hiding this comment.
There's also a change to the 2nd match group, from (.+?) to (.*?).
Changes in data callback are only refactoring
Yeah that's just so I could easily write a test to verify the regexes work.
|
Reviewed 2 of 2 files at r1. test/plugins/angular.test.js, line 39 [r1] (raw file):
not that it matters, but you're missing "from" here Comments from Reviewable |
close enuf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jrencz @mattrobenolt
This change is